Jump to content

Avatar

How to go about adding rhythm guitar to official DLC

RBHP rhythm guitar legacy legacy DLC disc songs

  • Please log in to reply
20 replies to this topic

#1 dr waffles

dr waffles
  • 25 posts

Posted December 25, 2017 - 06:56 PM

Ok, so I've gotten pretty far by just following the RBHP contribution guide, i can already extract the .mid file, add a 5-lane keyboard part, and update the .dta file to reflect that there is now a keys part. But once i load the song the game freezes, so what gives? Do i need to add a pro keyboard part as well? How can i do all this without screwing up the harmonies upgrades? Will the game freeze if the keyboardist has no animations?
 
as for the "Why?" im mostly doing this for personal use so my group of friends never have to worry about a 5th player effectively axeing half of our song selection.


#2 Fat Ha1p3rt

Fat Ha1p3rt
  • 400 posts
  • Location
    Michigan

Posted December 26, 2017 - 03:02 AM

Does the keys track have an audio channel? When you said that you edited the DTA file to take note of the changes, did you only add difficulty tiers for keys? Every playable instrument needs an audio track in the DTA or else it will crash upon loading.

 

dEPIBQP.png



#3 FujiSkunk

FujiSkunk
  • 703 posts
  • Location
    Planet Houston

Posted December 28, 2017 - 10:40 PM

A pro-keys chart isn't necessary if all you want is an extra 5-lane part to play.

 

As Fat Ha1p3rt mentioned, an audio track (one or more channels) must be mapped for every playable instrument part.  When adding a "keys" chart to a pre-RB3 song, the background track is appropriated for the keys part.  It's usually safe to assume the channel numbers for the background track are immediately after the vocal numbers, and it's usually safe to assume the background track is stereo (two channels) if any of the existing charts are attached to stereo tracks.  So, if you see "( 'vocals' (9 10) )" in the DTA, adding "( 'keys' (11 12) )" after that likely will map the correct track to a "keys" chart.



#4 dr waffles

dr waffles
  • 25 posts

Posted December 29, 2017 - 05:57 PM

Does the keys track have an audio channel? When you said that you edited the DTA file to take note of the changes, did you only add difficulty tiers for keys? Every playable instrument needs an audio track in the DTA or else it will crash upon loading.

 

dEPIBQP.png

I actually did that my first time trying this, i tested it with 2 songs, and it froze on both, I wasn't sure how the numbering worked, so when I saw every other upgrades pack had two more numbers that came after the vocals, I did the same thing. So if the keys has a difficulty rating, an audio track, and the midi file I add has [PART KEYS] in the text events, nothing should crash?



#5 Fat Ha1p3rt

Fat Ha1p3rt
  • 400 posts
  • Location
    Michigan

Posted December 30, 2017 - 01:02 AM

Hypothetically yes everything should be working as intended then. I'd say send me the files, but I'd assume that is against the rules. You can send me the .dta at least, that should be fine

#6 dr waffles

dr waffles
  • 25 posts

Posted December 31, 2017 - 02:53 AM

I'll try once again after new years, if it still doesn't work I send you some .dta files, thanks a ton.



#7 dr waffles

dr waffles
  • 25 posts

Posted January 2, 2018 - 08:20 AM

OMIGOSH IT WORKED! Ok, so very small issue, the guinea pig song I tried was Vasoline, any time there were multiple notes or chords in a row they would display as hammer ons, I'm assuming this is because of some note in the midi chart forcing the notes to be HOPOs, so just to recap I don't need to delete the song cache if i just change some notes right? I only need to change it if the dta file is different?



#8 Fat Ha1p3rt

Fat Ha1p3rt
  • 400 posts
  • Location
    Michigan

Posted January 2, 2018 - 07:10 PM

Correct. Although typically I like to get in the habit of updating the song ID and filename, but you should be fine in this case

#9 dr waffles

dr waffles
  • 25 posts

Posted January 14, 2018 - 05:55 AM

Ok so update, ive added rhythm guitar to six tracks, and they work fine when playing alone, as well as with two other instruments(drums and vocals) but when i load the song in a set list(while in all instruments mode) it crashes, ill run more tests to figure out what is exactly causing it to freeze (AIM, being in a setlist, etc.) but i genuinely don't know why a song would freeze in some conditions, but not in others.

#10 Fat Ha1p3rt

Fat Ha1p3rt
  • 400 posts
  • Location
    Michigan

Posted January 14, 2018 - 06:11 AM

That's very interesting. I'd love to take a look and mess around when them as well.

#11 dr waffles

dr waffles
  • 25 posts

Posted January 15, 2018 - 05:13 PM

ok, I tested it some more and realized all of them work in every scenario(aim, in a setlist etc.) except for monkey wrench, and that's only when the harmonies try to load, it freezes immediately, I'm pretty sure I just forgot to drag and drop a midi file but if you would still like to take a look yourself you're welcome to. how would I send you the files? I'm still new to posting on here.



#12 robypal

robypal
  • 21 posts

Posted January 15, 2018 - 05:33 PM

Dear dr waffles, any chance of you releasing these by any chance? Possibly in the RBHP fork with the new keyboard parts? Cheers in advance :D



#13 dr waffles

dr waffles
  • 25 posts

Posted January 15, 2018 - 05:47 PM

I would LOVE TO if a few people expressed interest, but there is a different standard I would have to hold myself to if I was going to release these to other people in the community. for example, in Afterlife I took some creative liberties and charted the strings section to rhythm guitar but only in the bridge, and I know many might consider that something that should strictly be for a keys part. also I'm not confident, or even interested in doing animations, although I make sure that reductions are handled well.



#14 Fat Ha1p3rt

Fat Ha1p3rt
  • 400 posts
  • Location
    Michigan

Posted January 17, 2018 - 11:03 AM

I would like to officially express interest. And lucky for you, using key upgrades breaks animations for the keyboardist anyway, so this isn't something you would need to worry about.



#15 robypal

robypal
  • 21 posts

Posted January 17, 2018 - 02:04 PM

Personally I'd say yay for creative liberties haha! These are OPTIONAL anyhow. I know and love the fact that charters on this site are perfectionists, but just stating my opinion haha
Anyhow, regardless of the outcome thanks for doing this :D



#16 dr waffles

dr waffles
  • 25 posts

Posted January 18, 2018 - 02:49 AM

This really motivates me to do more rhythm guitar upgrades. I want to go about it systematically, starting with rock band 1 songs, but there are times i just think of a random lego rock band song or something and think "that song would be so fun if it had rhythm guitar"

#17 Fat Ha1p3rt

Fat Ha1p3rt
  • 400 posts
  • Location
    Michigan

Posted January 18, 2018 - 03:24 AM

This really motivates me to do more rhythm guitar upgrades. I want to go about it systematically, starting with rock band 1 songs, but there are times i just think of a random lego rock band song or something and think "that song would be so fun if it had rhythm guitar"


I think this is a cool idea. If I can make a recommendation, it would probably make sense to focus on songs that don't have keys in the actual song. There are still many authors adding key upgrades to DLC, and I definitely prioritize key upgrades over rhythm guitar. That way you don't have to worry about someone adding a key upgrade to a song that you've already charted rhythm guitar for. I have a spreadsheet of a few hundred DLC songs and I sorted them into 2 groups: songs that need keys and songs that don't have keys in the song. That may be useful to you.

#18 dr waffles

dr waffles
  • 25 posts

Posted January 18, 2018 - 03:57 AM

I think this is a cool idea. If I can make a recommendation, it would probably make sense to focus on songs that don't have keys in the actual song. There are still many authors adding key upgrades to DLC, and I definitely prioritize key upgrades over rhythm guitar. That way you don't have to worry about someone adding a key upgrade to a song that you've already charted rhythm guitar for. I have a spreadsheet of a few hundred DLC songs and I sorted them into 2 groups: songs that need keys and songs that don't have keys in the song. That may be useful to you.


Oh yeah I actually had that thought from the start, one of the first i wanted to chart rhythm for was electric version, but when i noticed the keyboards in the mix I thought "damn, i really wish someone would do keys for this song". Knowing it might happen the road, i instead focused on charting rhythm for painkiller. But yeah I remember reading that keys spreadsheet you posted back when i was just lurking on the forums, i'll be sure to look into it.

#19 dr waffles

dr waffles
  • 25 posts

Posted January 29, 2018 - 06:43 AM

i've run into another issue, it's easy for me to add rhythm to songs like painkiller and afterlife because those have harmony upgrades already, so I figured I could just update the .mid and songs.dta, and then just leave the upgrades.dta as it is. essentially piggybacking off of the harmony upgrades, but what am I supposed to do with a song like Are You Gonna Be My Girl? There's no .dta files in the RBHP package(because there's no harmonies needed for that song), so...can I just copy the .dta file straight from the LIVE file of that song into a new folder labeled "areyougonnabemygirl'? don't I need the exact song id in the upgrades.dta for the upgrade to work? where can I find this? thanks in advance.



#20 Whizzer

Whizzer
  • 341 posts

Posted January 29, 2018 - 09:40 AM

i've run into another issue, it's easy for me to add rhythm to songs like painkiller and afterlife because those have harmony upgrades already, so I figured I could just update the .mid and songs.dta, and then just leave the upgrades.dta as it is. essentially piggybacking off of the harmony upgrades, but what am I supposed to do with a song like Are You Gonna Be My Girl? There's no .dta files in the RBHP package(because there's no harmonies needed for that song), so...can I just copy the .dta file straight from the LIVE file of that song into a new folder labeled "areyougonnabemygirl'? don't I need the exact song id in the upgrades.dta for the upgrade to work? where can I find this? thanks in advance.


You would need the updated information and song_id that can be found on the game disc. There's information elsewhere on how to get your hands on that, but it's against forum rules to share it here, I think.





Also tagged with one or more of these keywords: RBHP, rhythm guitar, legacy, legacy DLC, disc songs

0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users