Jump to content

Avatar

RBPH fork with new keyboard bits, and more!


  • Please log in to reply
74 replies to this topic

#61 ThatsGooodJason

ThatsGooodJason
  • 3 posts

Posted October 4, 2018 - 10:31 AM

is anyone else getting freezing any time they play one way or another or wonderwall? this happens whether I'm trying to sing harmonies or do keys. nothing looks wrong in the midis, so I'm not sure what's causing the problem.


This is happening to me as well. I've tried redownloading and repackaging, checking and unchecking Verbose, but keys just don't work for either of these songs.

#62 FujiSkunk

FujiSkunk
  • 855 posts
  • Location
    Planet Houston

Posted October 15, 2018 - 03:06 PM

This is happening to me as well. I've tried redownloading and repackaging, checking and unchecking Verbose, but keys just don't work for either of these songs.

 

Sorry, I missed these messages until I got a tap on the shoulder.  I really need to start looking at the forums more often.  I'll see if I can check these tonight (Monday the 15th) or at least this week and figure out what's going on.



#63 dr waffles

dr waffles
  • 31 posts

Posted October 24, 2018 - 09:31 AM

This is happening to me as well. I've tried redownloading and repackaging, checking and unchecking Verbose, but keys just don't work for either of these songs.

the way I fixed it for both songs was to bundle the upgrades with the songs directly, the c3 con tools tutorial video on youtube gives a good explanation on how to do this, it starts around 0:57:42.



#64 FujiSkunk

FujiSkunk
  • 855 posts
  • Location
    Planet Houston

Posted May 26, 2019 - 07:24 PM

It's been a long time coming, but we finally have new upgrades to show off.  As announced for C3X, the RBHP fork now has keys upgrades for the following 10 songs:

  • AFI - "Miss Murder" - keys by Linos Melendi
  • Carl Douglas - "Kung Fu Fighting" - keys by TheSheepQueen
  • Evanescence - "Call Me When You're Sober" - keys by Linos Melendi
  • Lady Gaga - "Bad Romance" - keys by Linos Melendi and FujiSkunk
  • Katrina and the Waves - "Walking on Sunshine" - keys by TheSheepQueen
  • Alanis Morisette - "You Oughta Know" -  keys by TheSheepQueen
  • Queen - "Another One Bites the Dust" - keys by TheSheepQueen
  • Scars on Broadway - "They Say" - keys by Linos Melendi
  • Shinedown - "Devour" - keys by Linos Melendi and FujiSkunk
  • We the Kings - "Check Yes Juliet" - keys by Linos Melendi and FujiSkunk

This latest update also includes the following fixes:

  • No Doubt - "Don't Speak" - corrected vocal tonic
  • Tom Petty - "Free Fallin'" - fixed sustain tails for pro keys and 5-lane keys

Additional upgrades and possible fixes are in the pipe, and I still plan on coordinating with other C3'ers to get even more goodies into the Project.  Stay tuned, and thanks to everyone who has contributed and who still plays, all these years later!



#65 ThatsGooodJason

ThatsGooodJason
  • 3 posts

Posted June 1, 2019 - 02:57 AM

Nice. Thanks for keeping this abandoned instrument in use for my Rock Band parties!

Did you ever figure out what was going on with One Way or Another and Wonderwall?

#66 Shroud

Shroud
  • 189 posts
  • Location
    EU

Posted June 1, 2019 - 06:45 AM

Interesting project... I have a couple of dumb questions :)

Since the additions are only in the _plus.mid file, I suppose that adding keys won't make their audio controlled by the player, right? Because that would require to change the mogg file as well.

Then also obviously, these updates require to have first exported songs into RB3?

#67 FujiSkunk

FujiSkunk
  • 855 posts
  • Location
    Planet Houston

Posted June 4, 2019 - 02:00 AM

Did you ever figure out what was going on with One Way or Another and Wonderwall?

 
Not yet, sorry.  Honestly those slipped my mind and my queue.  I'll do some investigating soon.
 

Interesting project... I have a couple of dumb questions :)

Since the additions are only in the _plus.mid file, I suppose that adding keys won't make their audio controlled by the player, right?


Actually keys will control keys audio... more or less.  Almost every song in the game, including every song with an available keys upgrade, has a "fifth" track for the background audio.  Each song's updated DTA has code that links that audio to the keys chart.  For some songs, it's a perfect solution.  For other songs it's not quite perfect, since missing a keys note will also cut out background vocals, extra instruments, and anything else in the background track.  But it's better than nothing, I think.
 

Then also obviously, these updates require to have first exported songs into RB3?


Yes, any song you wish to upgrade needs to be playable in RB3, either purchased as DLC in RB3 or prior (not purchased in RB4), or exported from the earlier discs.



#68 dr waffles

dr waffles
  • 31 posts

Posted September 28, 2019 - 08:43 AM

is anyone else having issues with the new upgrade pack? I've had my game freeze anytime just about any song on harms/keys is loaded that has upgrades, the strangest thing is the newest 10 keyboard upgrades are working fine(except for You Oughta Know), as well as some rhythm guitar upgrades of my own, but upgrades that I haven't even touched (and have always worked in the past) like and Justice for All and Cherub Rock are freezing on me, i've cleared the cache and reattached the upgrades 10+ times, even going so far as to use a newly unzipped rbhp-master folder and just copying the files without adding any of my own upgrades, and temporarily removing all my custom songs, still no luck.



#69 FujiSkunk

FujiSkunk
  • 855 posts
  • Location
    Planet Houston

Posted September 30, 2019 - 03:54 PM

"...And Justice for All" will have an issue if you also have the pro guitar upgrade released by Harmonix.

 

As for other songs, I'm not aware of any issues with the pack as a whole, though the last pack is fairly old (one more thing on my to-do list).  If you have the time to experiment, see if you have any different behavior when creating an RBHP bundle with just a handful of specific songs you see trouble with when using the pack.



#70 Shroud

Shroud
  • 189 posts
  • Location
    EU

Posted October 1, 2019 - 08:03 AM

I am interested in trying out some KEYS upgrades, and I have more questions.

 

I've made sure to include the other upgrade bits where appropriate, so that anyone who adds keys won't lose anything else, like harmonies or chart fixes.  

 

Does this mean that if I use the C3 CON Tools Upgrade Bundler to add the KEYS upgrade midi file, I will also get harmonies, pro guitar/bass, chart fixes, metadata fixes, and everything else? So in other words "KEYS" upgrades always contain everything? Or is there still some case when you need to add multiple upgrade midi files?

 

 

Several existing unison bonuses were in the middle of long sustained keyboard notes, which meant the keys couldn't really participate without something changing.  The options were to either move the other instruments' overdrive sections, or break up certain long sustained keys notes into shorter ones.  

 

Isn't there also the option of just not having keys participate to the unison? I think I stumbled upon a case which charting customs, and it was suggested by the authoring tutorials that keys are sometimes simply excluded from unisons.

 

Also, medium and easy pro keys medium share the same chart, as do medium and easy 5-lane keys, and hard and expert 5-lane keys.  I don't believe in knocking down difficulty artificially, and if the higher chart still follows all the rules for a lower difficulty, so be it.  Harmonix did it with the keys parts for "Helen Wheels", so I figure I can do it here.

 

Is this the case for all your keys charts or only some of them? Unless the keys part is so sparse or easy that it's nearly impossible to lower the difficulty further, I really think it's important to have 4 different difficulties. It's much better to slightly bend the "rules" at each difficulty in order to provide a good learning curve, than follow the rules blindly and ending up with sudden difficulty jumps (which is in fact a mistake done by Harmonix itself sometimes).

 

Only "Limelight" has nothing to play, and that's only because someone (Harmonix or the band or the record label, I don't know) didn't include the keys in the song's stem collection.

 

 

Didn't you just mention that in case of a keys upgrade the DTA file should redirect keys to the background stem? So why is the lack of a keys stem a problem?

 

Note, "21 Guns" is one of a handful of songs that have upgrades on the actual Rock Band 3 disc.  The official download files for "21 Guns" do not have harmonies, not even the Green Day Rock Band Plus export file.  Consequently the harmonies are supplied by the game disc (either the RB3 disc or the GDRB disc, depending on which game you're playing).  This could pose a problem to people who add the keys upgrade using the RBHP process, similar to how problems arise when the RBHP process is used on pre-RB3 songs with pro strings upgrades.  I can't say for sure because I haven't yet tried the RBHP process on "21 Guns" myself.  I can say that there are other means to add the keys upgrade to the song, and those means do play nice with the on-disc harmonies upgrade.  I suspect explaining the alternative is a little beyond what would be kosher to talk about here, so I'll leave that as an exercise for the reader.  We might all get lucky and the RBHP process works fine anyway.

 

This is something I really didn't know... so the Rock Band 3 game DISC includes some upgrades already for some DLC? Do you happen to know the list of the included upgrades?

 

EXTRA QUESTION: When I try to drag-and-drop some of your upgrades midi files in the C3 CON Tools Upgrade Bundler, I always gets a warning message that the EASY KEYS midi track is duplicate (in fact it shows up twice in the list of the included tracks) and the latest of the two will be used. Is this something happening to everyone, and why?



#71 dr waffles

dr waffles
  • 31 posts

Posted October 1, 2019 - 08:12 AM

ok so after like 7 hours of compiling, loading, freezing and repeating, i can confidently say it has something to do with some of the recent keys upgrades, specifically either kung fu fighting, walking on sunshine, you oughta know, check yes juliet, or maybe free fallin(since that chart was changed). I did a bundle with only those four songs and And Justice for All froze, so i removed those four songs and did a bundle of literally just the upgrade for AJFA and it worked, so i went into my upgrade folder, removed just those 5 upgrades and suddenly all my upgrades of every type worked no problem.

 

also to be clear I'm only mentioning AJFA because it's the quickest song to select that has an upgrade alphabetically, every time AJFA worked I immediately checked other upgrades and they all worked no problem. if i have time I can run a bundle with each new keys upgrade separately from each other to narrow down what was causing the freezing in the first place.



#72 dr waffles

dr waffles
  • 31 posts

Posted October 1, 2019 - 08:17 AM


Didn't you just mention that in case of a keys upgrade the DTA file should redirect keys to the background stem? So why is the lack of a keys stem a problem?

 

the problem is that the keys audio was removed entirely from the backing track of the rock band release, so if you were to add a keys upgrade, it wouldn't be tied to any audio of the keyboard playing, it's either tied to silence or whatever background noise is going on in limelight. it's a shame considering Rush is such a good band to benefit from keyboard.



#73 Shroud

Shroud
  • 189 posts
  • Location
    EU

Posted October 1, 2019 - 11:27 AM

 

the problem is that the keys audio was removed entirely from the backing track of the rock band release, so if you were to add a keys upgrade, it wouldn't be tied to any audio of the keyboard playing, it's either tied to silence or whatever background noise is going on in limelight. it's a shame considering Rush is such a good band to benefit from keyboard.

 

They completely removed the audio of an instrument? Weird... but that would make RB's version of this song a key-less version, so there is no point in adding playable keys.



#74 FujiSkunk

FujiSkunk
  • 855 posts
  • Location
    Planet Houston

Posted October 1, 2019 - 04:02 PM

Welcome to the rabbit hole, Shroud! :)
 

Does this mean that if I use the C3 CON Tools Upgrade Bundler to add the KEYS upgrade midi file, I will also get harmonies, pro guitar/bass, chart fixes, metadata fixes, and everything else? So in other words "KEYS" upgrades always contain everything? Or is there still some case when you need to add multiple upgrade midi files?

 
Essentially yes.  When using the RBHP bundler (different from the C3 CON Tools Upgrade Bundler), each optional upgrade directory is meant to overlay the base RBHP directory.  espher's tutorial explains this in more detail, but essentially you start with the base set of folders, and then one after the other, drag and drop each optional set of folders on top of the base set, allow the directories to merge and then allow any duplicates to copy over the existing files.  If my old reading is correct, the order is:

  • Song Info Fixes
  • Chart Fixes
  • Pro Guitar
  • Pro Keys
  • Misheard Lyrics

You can skip any of those you want, but the rest must be done in the prescribed order, otherwise you run the risk of say, losing pro keys on a song that has both pro guitar and pro keys.  Once you have a single set of folders with all the optional upgrade files copied in that you want, then you can feed that single set into the RBHP bundler.
 
When using the C3 CON Tools bundler, you can simply stick with the highest level upgrade that you want.  The keys files will in fact have any of the harmonies, song info fixes, chart fixes, and pro strings charts available, but they will not have any misheard lyric additions (there are extremely few of those anyway).
 

Isn't there also the option of just not having keys participate to the unison?

 
Yes, I could have gotten away with that, but I decided keys parts should be part of existing unison bonuses if at all possible, even if it means having a slightly less authentic chart as a result.
 

Is this the case for all your keys charts or only some of them?

 
Only some of them, and only in the cases you described, where keys are so sparse and/or easy that reducing isn't really necessary.
 

Didn't you just mention that in case of a keys upgrade the DTA file should redirect keys to the background stem? So why is the lack of a keys stem a problem?


As dr waffles explained, for whatever reason the keys in "Limelight" were left out of the Rock Band mix entirely, and like you said, that means there is nothing to play along with, not even in the background stem.  I didn't mean to imply the other songs have a dedicated keys stem, just that they have audible keys in the background stem, where "Limelight" does not.
 

This is something I really didn't know... so the Rock Band 3 game DISC includes some upgrades already for some DLC? Do you happen to know the list of the included upgrades?


Most of the on-disc "upgrades" are merely fixes.  Early DLC doesn't include album art the way later DLC does, so the RB3 disc has a lot of album art for those songs.  Also, as you know, all pre-RB3 songs have charting support for pro drums, but since no one could actually test pro drum support before RB3, many such songs had missing or extraneous tom markers.  The RB3 disc has some fixes for those too.  The only real "upgrades" beyond that are the harmonies for the Green Day songs and maybe harmonies for some Pearl Jam songs as well.
 

EXTRA QUESTION: When I try to drag-and-drop some of your upgrades midi files in the C3 CON Tools Upgrade Bundler, I always gets a warning message that the EASY KEYS midi track is duplicate (in fact it shows up twice in the list of the included tracks) and the latest of the two will be used. Is this something happening to everyone, and why?

 
Yes, this is normal.  I'm honestly not sure if the extra keys track is necessary when using the C3 CON Tools Upgrade Bundler, but at any rate it's a harmless warning that you can safely ignore.  espher discovered that an extra track is necessary when using the RBHP bundler, in order for the game to read keys properly.  Since the RBHP bundler takes advantage of the upgrade process normally used for pro guitar and bass upgrades, and it was never meant to be used as a hook for keys upgrades, there were a few quirks that had to be dealt with.  This is one such quirk.
 

ok so after like 7 hours of compiling, loading, freezing and repeating, i can confidently say it has something to do with some of the recent keys upgrades, specifically either kung fu fighting, walking on sunshine, you oughta know, check yes juliet, or maybe free fallin(since that chart was changed). I did a bundle with only those four songs and And Justice for All froze, so i removed those four songs and did a bundle of literally just the upgrade for AJFA and it worked, so i went into my upgrade folder, removed just those 5 upgrades and suddenly all my upgrades of every type worked no problem.
 
also to be clear I'm only mentioning AJFA because it's the quickest song to select that has an upgrade alphabetically, every time AJFA worked I immediately checked other upgrades and they all worked no problem. if i have time I can run a bundle with each new keys upgrade separately from each other to narrow down what was causing the freezing in the first place.


I appreciate your dedication to this, dr waffles, thank you!  I tend to use the C3 CON Tools Upgrade Bundler myself, and so I may have missed something with these latest upgrades that doesn't affect that process but screws something up when using the RBHP bundler.  Soon as I have time, I'll dig into what's going on.



#75 Shroud

Shroud
  • 189 posts
  • Location
    EU

Posted October 1, 2019 - 06:26 PM

Since the RBHP bundler takes advantage of the upgrade process normally used for pro guitar and bass upgrades, and it was never meant to be used as a hook for keys upgrades, there were a few quirks that had to be dealt with.  This is one such quirk.


Thanks for the most informative answers FujiSkunk! It's certainly amazing how many things about RB were never meant to be... but at the end, they are :)




0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users