Welcome to the rabbit hole, Shroud!
Does this mean that if I use the C3 CON Tools Upgrade Bundler to add the KEYS upgrade midi file, I will also get harmonies, pro guitar/bass, chart fixes, metadata fixes, and everything else? So in other words "KEYS" upgrades always contain everything? Or is there still some case when you need to add multiple upgrade midi files?
Essentially yes. When using the RBHP bundler (different from the C3 CON Tools Upgrade Bundler), each optional upgrade directory is meant to overlay the base RBHP directory. espher's tutorial explains this in more detail, but essentially you start with the base set of folders, and then one after the other, drag and drop each optional set of folders on top of the base set, allow the directories to merge and then allow any duplicates to copy over the existing files. If my old reading is correct, the order is:
- Song Info Fixes
- Chart Fixes
- Pro Guitar
- Pro Keys
- Misheard Lyrics
You can skip any of those you want, but the rest must be done in the prescribed order, otherwise you run the risk of say, losing pro keys on a song that has both pro guitar and pro keys. Once you have a single set of folders with all the optional upgrade files copied in that you want, then you can feed that single set into the RBHP bundler.
When using the C3 CON Tools bundler, you can simply stick with the highest level upgrade that you want. The keys files will in fact have any of the harmonies, song info fixes, chart fixes, and pro strings charts available, but they will not have any misheard lyric additions (there are extremely few of those anyway).
Isn't there also the option of just not having keys participate to the unison?
Yes, I could have gotten away with that, but I decided keys parts should be part of existing unison bonuses if at all possible, even if it means having a slightly less authentic chart as a result.
Is this the case for all your keys charts or only some of them?
Only some of them, and only in the cases you described, where keys are so sparse and/or easy that reducing isn't really necessary.
Didn't you just mention that in case of a keys upgrade the DTA file should redirect keys to the background stem? So why is the lack of a keys stem a problem?
As dr waffles explained, for whatever reason the keys in "Limelight" were left out of the Rock Band mix entirely, and like you said, that means there is nothing to play along with, not even in the background stem. I didn't mean to imply the other songs have a dedicated keys stem, just that they have audible keys in the background stem, where "Limelight" does not.
This is something I really didn't know... so the Rock Band 3 game DISC includes some upgrades already for some DLC? Do you happen to know the list of the included upgrades?
Most of the on-disc "upgrades" are merely fixes. Early DLC doesn't include album art the way later DLC does, so the RB3 disc has a lot of album art for those songs. Also, as you know, all pre-RB3 songs have charting support for pro drums, but since no one could actually test pro drum support before RB3, many such songs had missing or extraneous tom markers. The RB3 disc has some fixes for those too. The only real "upgrades" beyond that are the harmonies for the Green Day songs and maybe harmonies for some Pearl Jam songs as well.
EXTRA QUESTION: When I try to drag-and-drop some of your upgrades midi files in the C3 CON Tools Upgrade Bundler, I always gets a warning message that the EASY KEYS midi track is duplicate (in fact it shows up twice in the list of the included tracks) and the latest of the two will be used. Is this something happening to everyone, and why?
Yes, this is normal. I'm honestly not sure if the extra keys track is necessary when using the C3 CON Tools Upgrade Bundler, but at any rate it's a harmless warning that you can safely ignore. espher discovered that an extra track is necessary when using the RBHP bundler, in order for the game to read keys properly. Since the RBHP bundler takes advantage of the upgrade process normally used for pro guitar and bass upgrades, and it was never meant to be used as a hook for keys upgrades, there were a few quirks that had to be dealt with. This is one such quirk.
ok so after like 7 hours of compiling, loading, freezing and repeating, i can confidently say it has something to do with some of the recent keys upgrades, specifically either kung fu fighting, walking on sunshine, you oughta know, check yes juliet, or maybe free fallin(since that chart was changed). I did a bundle with only those four songs and And Justice for All froze, so i removed those four songs and did a bundle of literally just the upgrade for AJFA and it worked, so i went into my upgrade folder, removed just those 5 upgrades and suddenly all my upgrades of every type worked no problem.
also to be clear I'm only mentioning AJFA because it's the quickest song to select that has an upgrade alphabetically, every time AJFA worked I immediately checked other upgrades and they all worked no problem. if i have time I can run a bundle with each new keys upgrade separately from each other to narrow down what was causing the freezing in the first place.
I appreciate your dedication to this, dr waffles, thank you! I tend to use the C3 CON Tools Upgrade Bundler myself, and so I may have missed something with these latest upgrades that doesn't affect that process but screws something up when using the RBHP bundler. Soon as I have time, I'll dig into what's going on.