Jump to content

Avatar

Thoughts on using a repository?


  • Please log in to reply
25 replies to this topic

#1 espher

espher

    Harmonies Hacker

  • Administrator
  • 1,900 posts
  • Location
    Canada

Posted February 7, 2016 - 07:53 PM

So I've been mulling over trying to throw RBHP on GitHub or a similar repository. It's obviously not code or plaintext, for the most part, but the prospect of built-in versioning and other contributors being able to throw things up there and/or submit fixes and stuff appeals to me. Might make it easier for me to manage things like submissions, bug reports, etc, etc.

 

I could still periodically pull down a copy of everything on there and upload it as a new 'release', but would there be any benefit for anyone else here to me going that route?

 

May also be useful if I ever go ahead and start developing that web-based packager... ;)


C3 Author/Admin, Project Lead for the Rock Band: Harmonies Project


#2 MFX

MFX
  • 389 posts

Posted February 7, 2016 - 08:20 PM

It would benefit me. I've been looking into new ways to manipulate metadata to offer more sorting flexibility, and being able to shim some post-processing in would be nice.



#3 FujiSkunk

FujiSkunk
  • 677 posts
  • Location
    Planet Houston

Posted February 8, 2016 - 02:20 AM

Sounds like a good idea.  People could pull the latest snapshot whenever they want.  Speaking personally, it would give me incentive to learn a new versioning control system, assuming you use something other than Subversion.

 

I agree that something like this would benefit from a packager.  Otherwise you'll have to rely on contributors to add their updates to all the right combinations of files, which could prove a bit of a challenge.



#4 espher

espher

    Harmonies Hacker

  • Administrator
  • 1,900 posts
  • Location
    Canada

Posted February 8, 2016 - 02:06 PM

Alright. I'll have to look some options over. I've never really done any repository stuff before (my version control at home/work has always been "copy folder to external storage/network share, rename to include timestamp", but I'm not really a developer, so...) and this isn't exactly a coding project.

 

Might try to do it up this coming weekend. I am 200% open to suggestions.

 

I do think it would be much better to do it this way since other people can just add their crap instead of e-mailing or PMing me and me completely forgetting about it because I am unreliable like that. ;)


C3 Author/Admin, Project Lead for the Rock Band: Harmonies Project


#5 Whizzer

Whizzer
  • 239 posts

Posted February 9, 2016 - 09:07 PM

I'm very much in favor of this.

 

Before the final harmonies upgrade, I've found some errors here and there, but haven't yet checked all the files. I will probably start over with the new final release, slowly checking every single file, adding a couple every week.

 

Thanks for all the hard work!



#6 espher

espher

    Harmonies Hacker

  • Administrator
  • 1,900 posts
  • Location
    Canada

Posted February 11, 2016 - 03:14 PM

Yeah, I had been playing through RB4 and updating RBHP tracks on my end (and compiling feedback) but had put that on hold waiting for updates. I'm likely going to pick it up again since there's an update coming in April and a) I don't want to wait that long before I do anything and B) the stuff they fixed will be stuff I need to fix, probably. :P

 

So a repository may be good to avoid duplication of effort.


C3 Author/Admin, Project Lead for the Rock Band: Harmonies Project


#7 espher

espher

    Harmonies Hacker

  • Administrator
  • 1,900 posts
  • Location
    Canada

Posted February 15, 2016 - 01:56 PM

Alright, I had to fight with the desktop client yesterday, but I did get a repository in place which has the latest public release:

 

https://github.com/rbhp-espher/rbhp

 

I went ahead and made a new branch to account for any changes since then (which I have not yet uploaded) or for any submissions other people want to make:

 

https://github.com/r...-quarter-update

 

I legitimately have no clue what I am doing but I'll see if I can add any of you who are interested in making submissions and we'll go from there. I also have to do things like clean up the upgrades.dta RBHP-specific metadata in songs. Many still list me as the author or have the rbhp_version as 1/0. I will be tweaking those and the versions in the repository as of creation of the master branch (so, from the end of last year) will be v1.


C3 Author/Admin, Project Lead for the Rock Band: Harmonies Project


#8 FujiSkunk

FujiSkunk
  • 677 posts
  • Location
    Planet Houston

Posted February 16, 2016 - 09:40 PM

I volunteer!



#9 Whizzer

Whizzer
  • 239 posts

Posted February 17, 2016 - 11:32 PM

Yeah, I had been playing through RB4 and updating RBHP tracks on my end (and compiling feedback) but had put that on hold waiting for updates. I'm likely going to pick it up again since there's an update coming in April and a) I don't want to wait that long before I do anything and B) the stuff they fixed will be stuff I need to fix, probably. :P

 

So a repository may be good to avoid duplication of effort.

Update for RB4, or planned RB:HP update?
 

Either way, sign me up. I'm willing to check midi and .dta files.



#10 espher

espher

    Harmonies Hacker

  • Administrator
  • 1,900 posts
  • Location
    Canada

Posted February 19, 2016 - 04:11 AM

It's an update for RB:HP on my end, though I'm compiling things I noticed into a bug list that I will provide (maybe on the community bug tracker thing or through some other means).

 

I've run through about a quarter to a fifth of the list so far, iirc, and it's mostly minor cosmetic stuff, though I do know from reports there are some 'bigger fish', so to speak.


C3 Author/Admin, Project Lead for the Rock Band: Harmonies Project


#11 espher

espher

    Harmonies Hacker

  • Administrator
  • 1,900 posts
  • Location
    Canada

Posted March 1, 2016 - 12:06 PM

I spent the better part of this weekend fighting with Github for Desktop, and gave up yesterday evening, so I'll be trying with something else to see if I can get this working. I certainly haven't given up on the idea. ;)


C3 Author/Admin, Project Lead for the Rock Band: Harmonies Project


#12 Linos Melendi

Linos Melendi
  • 113 posts
  • Location
    North Carolina

Posted March 8, 2016 - 05:57 PM

So I tried submitting 2 keys upgrades with a pull request. No idea if I did it right, never used github before.


My customs thread

 

My customs spreadsheet (120+ songs)

 

The 0.1% of Pro Keys players

 


#13 espher

espher

    Harmonies Hacker

  • Administrator
  • 1,900 posts
  • Location
    Canada

Posted March 12, 2016 - 03:23 AM

I think you did it right. At least, you did if I did, lol.


C3 Author/Admin, Project Lead for the Rock Band: Harmonies Project


#14 Sideshow

Sideshow
  • 2,468 posts
  • Location
    Southern California

Posted March 12, 2016 - 04:17 AM

I've gathered up several official dlc songs that need fixes to the pro drums.  Going to try this github way of submitting songs when I have some done.  If any other contributors out there is working on Pro Drum fixes let me know so we don't duplicate our work.



#15 Sideshow

Sideshow
  • 2,468 posts
  • Location
    Southern California

Posted March 12, 2016 - 11:35 PM

I submitted the following pro drum fixes:

 

Avenged Sevenfold "Bat Country"

Bon Jovi "You Give Love a Bad Name"

Deep Purple "Spacetruckin"

Deftones "Cherry Waves"

Deftones "Hole in the Earth"

Freezepop "ScienceGeniusGirl"

Foo Fighters "Breakout"

Green Day "EmeniusSleepus"

Green Day "Homecoming"

Iron Maiden "The Clairvoyant"

Kansas "Icarus"

The Cars "I'm In Touch With Your World"

 

More to come.



#16 Sideshow

Sideshow
  • 2,468 posts
  • Location
    Southern California

Posted March 13, 2016 - 07:12 PM

Here are the last songs I have in my que that I have posted:

 

No Doubt "Different People"

Pearl Jam "Deep"

Pearl Jam "Porch"

Pixies "Debaser"

Queen "We are the Champions" (Lego Rock Band version)

Red Hot Chili Peppers "They Are Red Hot"

Soundgarden "Black Hole Sun"

The Offspring "Hammerhead"

Green Day "Holiday"

 

I took a look at NIN "Perfect Drug" but didn't make any changes because I believe the author made the yellow hi hats and yellow toms intentional based off of the drummer animations. 

 

Please let me know if any other RB1 - RB2 era drum songs have issues on Pro Drums and I'll take a look at it.



#17 Whizzer

Whizzer
  • 239 posts

Posted March 13, 2016 - 09:13 PM

Do you have a list of what's fixed? Thanks either way!



#18 Sideshow

Sideshow
  • 2,468 posts
  • Location
    Southern California

Posted March 13, 2016 - 10:06 PM

Do you have a list of what's fixed? Thanks either way!

http://forums.harmon...drums-errors/p1

 

I've gathered most of my clues from this official forum thread.  Majority of issues are from disco flip events located on pre RB3 songs that cause issues with yellow toms not showing up properly for Pro Drummers.  I've also found several tom marker notations not placed properly.  I'd imagine back in RB1 - RB2 days the Harmonix QA was probably not instructed to check for this stuff due to there not being Pro Drums yet.  Luckily a majority of the back catalog doesn't have issues.



#19 ElectricSkylab

ElectricSkylab
  • 79 posts

Posted March 25, 2016 - 09:16 PM

Please let me know if any other RB1 - RB2 era drum songs have issues on Pro Drums and I'll take a look at it.

 

The Who's "Summertime Blues (Live at Leeds)" has a yellow cymbal that should be a tom.

 

At 0:32 here: 



#20 Sideshow

Sideshow
  • 2,468 posts
  • Location
    Southern California

Posted March 26, 2016 - 01:13 AM

Thanks for the error find.  The yellow tom marker was just barely missing the note which is why it was showing up as a cymbal.  I fixed it and submitted it to Espher.






0 user(s) are reading this topic

0 members, 0 guests, 0 anonymous users